diff options
| author | Jeffy Chen | 2017-07-20 18:53:50 +0800 |
|---|---|---|
| committer | Marcel Holtmann | 2017-07-24 18:55:14 +0200 |
| commit | 19cfe912c37bbc184c673c3c081edff62ea8e565 (patch) | |
| tree | 52d9ff9a8da6dc305bd771f18c1b5e344d1ffabf /.cocciconfig | |
| parent | d98422cb6619408f1779457fefc5da983fc6bc3b (diff) | |
Bluetooth: btusb: Fix memory leak in play_deferred
Currently we are calling usb_submit_urb directly to submit deferred tx
urbs after unanchor them.
So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb
and cause memory leak:
unreferenced object 0xffffffc0ce0fa400 (size 256):
...
backtrace:
[<ffffffc00034a9a8>] __save_stack_trace+0x48/0x6c
[<ffffffc00034b088>] create_object+0x138/0x254
[<ffffffc0009d5504>] kmemleak_alloc+0x58/0x8c
[<ffffffc000345f78>] __kmalloc+0x1d4/0x2a0
[<ffffffc0006765bc>] usb_alloc_urb+0x30/0x60
[<ffffffbffc128598>] alloc_ctrl_urb+0x38/0x120 [btusb]
[<ffffffbffc129e7c>] btusb_send_frame+0x64/0xf8 [btusb]
Put those urbs in tx_anchor to avoid the leak, and also fix the error
handling.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions