aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMadhuparna Bhowmik2020-02-19 20:47:46 +0530
committerDavid S. Miller2020-02-19 11:13:43 -0800
commit33c4acbe2f4e8f2866914b1fb90ce74fc7216c21 (patch)
treef46fcc3c35f1b79b12eb552f993f2921b2c2802e
parentc3331d2fe3fd4d5e321f2467d01f72de7edfb5d0 (diff)
bridge: br_stp: Use built-in RCU list checking
list_for_each_entry_rcu() has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu() to silence false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled by default. Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/bridge/br_stp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index 6856a6d9282b..1f14b8455345 100644
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -63,7 +63,8 @@ struct net_bridge_port *br_get_port(struct net_bridge *br, u16 port_no)
{
struct net_bridge_port *p;
- list_for_each_entry_rcu(p, &br->port_list, list) {
+ list_for_each_entry_rcu(p, &br->port_list, list,
+ lockdep_is_held(&br->lock)) {
if (p->port_no == port_no)
return p;
}