aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Howells2020-04-08 17:32:10 +0100
committerDavid Howells2020-04-13 15:09:01 +0100
commit3e0d9892c0e7fa426ca6bf921cb4b543ca265714 (patch)
tree79f6f8d3ff45bff5f5af3ec2a3a4529bf2fb008d
parentc72057b56f7e24865840a6961d801a7f21d30a5f (diff)
afs: Fix decoding of inline abort codes from version 1 status records
If we're decoding an AFSFetchStatus record and we see that the version is 1 and the abort code is set and we're expecting inline errors, then we store the abort code and ignore the remaining status record (which is correct), but we don't set the flag to say we got a valid abort code. This can affect operation of YFS.RemoveFile2 when removing a file and the operation of {,Y}FS.InlineBulkStatus when prospectively constructing or updating of a set of inodes during a lookup. Fix this to indicate the reception of a valid abort code. Fixes: a38a75581e6e ("afs: Fix unlink to handle YFS.RemoveFile2 better") Signed-off-by: David Howells <dhowells@redhat.com>
-rw-r--r--fs/afs/fsclient.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/afs/fsclient.c b/fs/afs/fsclient.c
index fae73e13976a..de4331670c84 100644
--- a/fs/afs/fsclient.c
+++ b/fs/afs/fsclient.c
@@ -88,6 +88,7 @@ static int xdr_decode_AFSFetchStatus(const __be32 **_bp,
if (abort_code != 0 && inline_error) {
status->abort_code = abort_code;
+ scb->have_error = true;
goto good;
}