aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSven Peter2023-11-26 17:20:09 +0100
committerJoerg Roedel2023-11-27 11:16:38 +0100
commit60732292a135e8b8152858f219a563c05e9569e9 (patch)
tree60b96293c74d630b78403592ff68c7de3f8792e4
parent863c092323ab17a5bc4b2f3185d4136f9e57bbe3 (diff)
iommu/apple-dart: Use readl instead of readl_relaxed for consistency
While the readl_relaxed in apple_dart_suspend is correct the rest of the driver uses the non-relaxed variants everywhere and the single readl_relaxed is inconsistent and possibly confusing. Signed-off-by: Sven Peter <sven@svenpeter.dev> Acked-by: Hector Martin <marcan@marcan.st> Reviewed-by: Neal Gompa <neal@gompa.dev> Link: https://lore.kernel.org/r/20231126162009.17934-1-sven@svenpeter.dev Signed-off-by: Joerg Roedel <jroedel@suse.de>
-rw-r--r--drivers/iommu/apple-dart.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index f47f60c0a4d0..7438e9c82ba9 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -1302,7 +1302,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev)
unsigned int sid, idx;
for (sid = 0; sid < dart->num_streams; sid++) {
- dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid));
+ dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid));
for (idx = 0; idx < dart->hw->ttbr_count; idx++)
dart->save_ttbr[sid][idx] =
readl(dart->regs + DART_TTBR(dart, sid, idx));