aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Xing2024-03-04 16:20:45 +0800
committerPaolo Abeni2024-03-07 10:36:58 +0100
commitbc76645ebdd01be9b9994dac39685a3d0f6f7985 (patch)
treef28f7700352daa48397480e6fb11f67e57edd9b9
parentb5dffcb8f71bdd02a4e5799985b51b12f4eeaf76 (diff)
netrom: Fix a data-race around sysctl_netrom_link_fails_count
We need to protect the reader reading the sysctl value because the value can be changed concurrently. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Jason Xing <kernelxing@tencent.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
-rw-r--r--net/netrom/nr_route.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 89e12e6eea2e..70480869ad1c 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -728,7 +728,7 @@ void nr_link_failed(ax25_cb *ax25, int reason)
nr_neigh->ax25 = NULL;
ax25_cb_put(ax25);
- if (++nr_neigh->failed < sysctl_netrom_link_fails_count) {
+ if (++nr_neigh->failed < READ_ONCE(sysctl_netrom_link_fails_count)) {
nr_neigh_put(nr_neigh);
return;
}