diff options
| author | Pablo Neira Ayuso | 2016-11-03 10:56:05 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso | 2016-11-03 10:56:05 +0100 |
| commit | d2be66f6858d6243395763cb643de55bad96d33d (patch) | |
| tree | 260d8c6e421970f59d68947c18b85f574ddbd428 | |
| parent | b250a7fc3bbec80a3c4717a262863d93f4146b88 (diff) | |
netfilter: remove comments that predate rcu days
We cannot block/sleep on nf_iterate because netfilter runs under rcu
read lock these days, where blocking is well-known to be illegal. So
let's remove these old comments.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | net/netfilter/core.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/net/netfilter/core.c b/net/netfilter/core.c index 3d4aa96cb219..76014ad72ec5 100644 --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -308,18 +308,11 @@ unsigned int nf_iterate(struct sk_buff *skb, { unsigned int verdict; - /* - * The caller must not block between calls to this - * function because of risk of continuing from deleted element. - */ while (*entryp) { if (state->thresh > (*entryp)->ops.priority) { *entryp = rcu_dereference((*entryp)->next); continue; } - - /* Optimization: we don't need to hold module - reference here, since function can't sleep. --RR */ repeat: verdict = (*entryp)->ops.hook((*entryp)->ops.priv, skb, state); if (verdict != NF_ACCEPT) { |