diff options
| author | Johannes Berg | 2021-09-27 13:44:03 +0200 |
|---|---|---|
| committer | Johannes Berg | 2021-09-27 15:32:54 +0200 |
| commit | 05075fe7455a210769b266e62a0040ddc98b2739 (patch) | |
| tree | 8079b13909d5f95d9b188788dbed5860b72cb994 | |
| parent | e53e9828a8d2c6545e01ff9711f1221f2fd199ce (diff) | |
nl80211: don't kfree() ERR_PTR() value
When parse_acl_data() fails, we get an ERR_PTR() value and
then "goto out;", in this case we'd attempt to kfree() it.
Fix that.
Fixes: 9e263e193af7 ("nl80211: don't put struct cfg80211_ap_settings on stack")
Link: https://lore.kernel.org/r/20210927134402.86c5ae06c952.Ic51e234d998b9045665e5ff8b6db7e29f25d70c0@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
| -rw-r--r-- | net/wireless/nl80211.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index d7c03f6145f0..0f728de36f33 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5507,6 +5507,7 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info) params->acl = parse_acl_data(&rdev->wiphy, info); if (IS_ERR(params->acl)) { err = PTR_ERR(params->acl); + params->acl = NULL; goto out; } } |