aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTrond Myklebust2020-01-06 15:25:00 -0500
committerAnna Schumaker2020-01-15 10:54:32 -0500
commit0df68ced55443243951d02cc497be31fadf28173 (patch)
tree8a893c208d8ae8f51e24fae0d128cd4cd35fd687
parente515dd9d76d22446b67f1568e3fc39ec84635360 (diff)
NFS: Revalidate the file size on a fatal write error
If we suffer a fatal error upon writing a file, which causes us to need to revalidate the entire mapping, then we should also revalidate the file size. Fixes: d2ceb7e57086 ("NFS: Don't use page_file_mapping after removing the page") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
-rw-r--r--fs/nfs/write.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 21787711e352..adedc16780c5 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -243,7 +243,15 @@ out:
/* A writeback failed: mark the page as bad, and invalidate the page cache */
static void nfs_set_pageerror(struct address_space *mapping)
{
+ struct inode *inode = mapping->host;
+
nfs_zap_mapping(mapping->host, mapping);
+ /* Force file size revalidation */
+ spin_lock(&inode->i_lock);
+ NFS_I(inode)->cache_validity |= NFS_INO_REVAL_FORCED |
+ NFS_INO_REVAL_PAGECACHE |
+ NFS_INO_INVALID_SIZE;
+ spin_unlock(&inode->i_lock);
}
static void nfs_mapping_set_error(struct page *page, int error)