diff options
| author | Daniel Vetter | 2018-05-02 09:51:06 +0200 |
|---|---|---|
| committer | Jonathan Corbet | 2018-05-08 08:51:03 -0600 |
| commit | 1897e8f394c50124f90d6c1be672f05846438bf8 (patch) | |
| tree | caea8566194c4037268c574afcfcba35e98e0931 | |
| parent | c9161088e54b56d7ff8c92fd9e18b0fb7a20b2b3 (diff) | |
doc: botching-up-ioctls: Make it clearer why structs must be padded
This came up in discussions when reviewing drm patches.
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
| -rw-r--r-- | Documentation/ioctl/botching-up-ioctls.txt | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Documentation/ioctl/botching-up-ioctls.txt b/Documentation/ioctl/botching-up-ioctls.txt index d02cfb48901c..883fb034bd04 100644 --- a/Documentation/ioctl/botching-up-ioctls.txt +++ b/Documentation/ioctl/botching-up-ioctls.txt @@ -73,7 +73,9 @@ will have a second iteration or at least an extension for any given interface. future extensions is going right down the gutters since someone will submit an ioctl struct with random stack garbage in the yet unused parts. Which then bakes in the ABI that those fields can never be used for anything else - but garbage. + but garbage. This is also the reason why you must explicitly pad all + structures, even if you never use them in an array - the padding the compiler + might insert could contain garbage. * Have simple testcases for all of the above. |