aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUladzislau Rezki (Sony)2022-06-07 11:34:47 +0200
committerakpm2022-07-03 18:08:41 -0700
commit5d7a7c54d3d7ff2f54725881dc7e06a7f5c94dc2 (patch)
treeb5aa0c7195f53ba961585e8c2ac864c3aad56721
parentf9863be49312aa1f566dca12603e33487965e6a4 (diff)
mm/vmalloc: initialize VA's list node after unlink
A vmap_area can travel between different places. For example attached/detached to/from different rb-trees. In order to prevent fancy bugs, initialize a VA's list node after it is removed from the list, so it pairs with VA's rb_node which is also initialized. There is no functional change as a result of this patch. Link: https://lkml.kernel.org/r/20220607093449.3100-4-urezki@gmail.com Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> Reviewed-by: Baoquan He <bhe@redhat.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Matthew Wilcox <willy@infradead.org> Cc: Nicholas Piggin <npiggin@gmail.com> Cc: Oleksiy Avramchenko <oleksiy.avramchenko@sony.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r--mm/vmalloc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 5dce7593c075..58cfecb2ec26 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -977,7 +977,7 @@ __unlink_va(struct vmap_area *va, struct rb_root *root, bool augment)
else
rb_erase(&va->rb_node, root);
- list_del(&va->list);
+ list_del_init(&va->list);
RB_CLEAR_NODE(&va->rb_node);
}