aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDylan Reid2012-06-21 21:51:22 -0700
committerTakashi Iwai2012-06-22 09:08:58 +0200
commitb43d224767e426cf1a8b6622d1d172f2b2b0e857 (patch)
tree0109819c40a3661372c36b400fdf4cd8db69f21a
parente9ea8e8f229f4963bf01658e79c1c01780de25dd (diff)
ALSA: hda - Don't power up when not powered down.
After cancel_delayed_work_sync returns, the power down work either never started (power_on == 1) or finished (power_on == 0). In the former case there is no need to power up again. Signed-off-by: Dylan Reid <dgreid@chromium.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/hda/hda_codec.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 604699cf85f5..045b5e7b8245 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -4444,6 +4444,13 @@ static void __snd_hda_power_up(struct hda_codec *codec, bool wait_power_down)
cancel_delayed_work_sync(&codec->power_work);
spin_lock(&codec->power_lock);
+ /* If the power down delayed work was cancelled above before starting,
+ * then there is no need to go through power up here.
+ */
+ if (codec->power_on) {
+ spin_unlock(&codec->power_lock);
+ return;
+ }
trace_hda_power_up(codec);
snd_hda_update_power_acct(codec);
codec->power_on = 1;