diff options
| author | Robin Dong | 2011-07-11 11:43:59 -0400 |
|---|---|---|
| committer | Theodore Ts'o | 2011-07-11 11:43:59 -0400 |
| commit | ffb505ff0f7b52318dea46dd139107a8371b4ad7 (patch) | |
| tree | e94a4af0c694d5ce79d512be8e8e390da43b9e66 | |
| parent | 22612283f7da1ce9849d9b3716010b07a0446fd9 (diff) | |
ext4: remove redundant goto in ext4_ext_insert_extent()
If eh->eh_entries is smaller than eh->eh_max, the routine will
go to the "repeat" and then go to "has_space" directlly ,
since argument "depth" and "eh" are not even changed.
Therefore, goto "has_space" directly and remove redundant "repeat" tag.
Signed-off-by: Robin Dong <sanbai@taobao.com>
| -rw-r--r-- | fs/ext4/extents.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index c969ae23a535..9cbdcb2110f5 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -1723,7 +1723,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, goto merge; } -repeat: depth = ext_depth(inode); eh = path[depth].p_hdr; if (le16_to_cpu(eh->eh_entries) < le16_to_cpu(eh->eh_max)) @@ -1745,7 +1744,7 @@ repeat: ext_debug("next leaf isn't full(%d)\n", le16_to_cpu(eh->eh_entries)); path = npath; - goto repeat; + goto has_space; } ext_debug("next leaf has no free space(%d,%d)\n", le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max)); |