diff options
| author | Dan Carpenter | 2023-06-19 12:44:17 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2023-10-06 14:56:48 +0200 |
| commit | 33ed60d8b961fca23a96f3a2f0c7c142c6ec5455 (patch) | |
| tree | fffc1b46d4d86d71e4954f3b1a32c3401a200d3b | |
| parent | 1ec48a9fac7d07c70e12147949e4941b1c2db3d2 (diff) | |
power: supply: ucs1002: fix error code in ucs1002_get_property()
[ Upstream commit e35059949daa83f8dadf710d0f829ab3c3a72fe2 ]
This function is supposed to return 0 for success instead of returning
the val->intval. This makes it the same as the other case statements
in this function.
Fixes: 81196e2e57fc ("power: supply: ucs1002: fix some health status issues")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/687f64a4-4c6e-4536-8204-98ad1df934e5@moroto.mountain
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/power/supply/ucs1002_power.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c index ef673ec3db56..332cb50d9fb4 100644 --- a/drivers/power/supply/ucs1002_power.c +++ b/drivers/power/supply/ucs1002_power.c @@ -384,7 +384,8 @@ static int ucs1002_get_property(struct power_supply *psy, case POWER_SUPPLY_PROP_USB_TYPE: return ucs1002_get_usb_type(info, val); case POWER_SUPPLY_PROP_HEALTH: - return val->intval = info->health; + val->intval = info->health; + return 0; case POWER_SUPPLY_PROP_PRESENT: val->intval = info->present; return 0; |