aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhang Xiaoxu2020-11-16 08:58:10 -0500
committerBorislav Petkov2020-11-18 18:59:47 +0100
commit61d35648c06cac042d88c6d0b8df8f8c8c72a4d4 (patch)
tree15259beb927bc5007cc3bd57a2256ccba1b8dabf
parent211f737ac76ac317b67fa903742e92236d5776df (diff)
EDAC/synopsys: Return the correct value in mc_probe()
Return the error value if the inject sysfs file creation fails, rather than returning 0, to signal to the upper layer that the ->probe function failed. [ bp: Massage. ] Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com> Signed-off-by: Borislav Petkov <bp@suse.de> Reviewed-by: Michal Simek <michal.simek@xilinx.com> Link: https://lkml.kernel.org/r/20201116135810.3130845-1-zhangxiaoxu5@huawei.com
-rw-r--r--drivers/edac/synopsys_edac.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index 12211dc040e8..7e7146b22c16 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -1344,7 +1344,8 @@ static int mc_probe(struct platform_device *pdev)
#ifdef CONFIG_EDAC_DEBUG
if (priv->p_data->quirks & DDR_ECC_DATA_POISON_SUPPORT) {
- if (edac_create_sysfs_attributes(mci)) {
+ rc = edac_create_sysfs_attributes(mci);
+ if (rc) {
edac_printk(KERN_ERR, EDAC_MC,
"Failed to create sysfs entries\n");
goto free_edac_mc;