diff options
author | Pavel Begunkov | 2020-12-18 13:12:21 +0000 |
---|---|---|
committer | Jens Axboe | 2020-12-18 08:16:02 -0700 |
commit | dfea9fce29fda6f2f91161677e0e0d9b671bc099 (patch) | |
tree | 1ffc275505aa4dce6554785700cbf51d2c268f20 /Documentation/hwmon/userspace-tools.rst | |
parent | 0020ef04e48571a88d4f482ad08f71052c5c5a08 (diff) |
io_uring: close a small race gap for files cancel
The purpose of io_uring_cancel_files() is to wait for all requests
matching ->files to go/be cancelled. We should first drop files of a
request in io_req_drop_files() and only then make it undiscoverable for
io_uring_cancel_files.
First drop, then delete from list. It's ok to leave req->id->files
dangling, because it's not dereferenced by cancellation code, only
compared against. It would potentially go to sleep and be awaken by
following in io_req_drop_files() wake_up().
Fixes: 0f2122045b946 ("io_uring: don't rely on weak ->files references")
Cc: <stable@vger.kernel.org> # 5.5+
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'Documentation/hwmon/userspace-tools.rst')
0 files changed, 0 insertions, 0 deletions