diff options
author | Tejun Heo | 2015-08-18 14:54:57 -0700 |
---|---|---|
committer | Jens Axboe | 2015-08-18 15:49:15 -0700 |
commit | 4ebc1c61d6185604c97fd0b0355ab668052044ab (patch) | |
tree | 366acca07997da745139dba40070eea624f768b9 /Documentation/unicode.txt | |
parent | 5634cc2aa9aebc77bc862992e7805469dcf83dac (diff) |
cfq-iosched: simplify control flow in cfq_get_queue()
cfq_get_queue()'s control flow looks like the following.
async_cfqq = NULL;
cfqq = NULL;
if (!is_sync) {
...
async_cfqq = ...;
cfqq = *async_cfqq;
}
if (!cfqq)
cfqq = ...;
if (!is_sync && !(*async_cfqq))
...;
The only thing the local variable init, the second if, and the
async_cfqq test in the third if achieves is to skip cfqq creation and
installation if *async_cfqq was already non-NULL. This is needlessly
complicated with different tests examining the same condition.
Simplify it to the following.
if (!is_sync) {
...
async_cfqq = ...;
cfqq = *async_cfqq;
if (cfqq)
goto out;
}
cfqq = ...;
if (!is_sync)
...;
out:
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Arianna Avanzini <avanzini.arianna@gmail.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'Documentation/unicode.txt')
0 files changed, 0 insertions, 0 deletions