diff options
author | Gao Xiang | 2020-06-19 07:43:49 +0800 |
---|---|---|
committer | Gao Xiang | 2020-06-24 09:47:44 +0800 |
commit | 3c597282887fd55181578996dca52ce697d985a5 (patch) | |
tree | f4c82f3cc413ff2bcafa43debfa3e0e07cd14081 /Documentation | |
parent | b3a9e3b9622ae10064826dccb4f7a52bd88c7407 (diff) |
erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup
Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with
specific aarch64 environment easily, which wasn't shown before.
After digging into that, I found that high 32 bits of page->private
was set to 0xaaaaaaaa rather than 0 (due to z_erofs_onlinepage_init
behavior with specific compiler options). Actually we only use low
32 bits to keep the page information since page->private is only 4
bytes on most 32-bit platforms. However z_erofs_onlinepage_fixup()
uses the upper 32 bits by mistake.
Let's fix it now.
Reported-and-tested-by: Hongyu Jin <hongyu.jin@unisoc.com>
Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20200618234349.22553-1-hsiangkao@aol.com
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions