diff options
| author | Chuck Ebbert | 2006-02-04 23:28:03 -0800 |
|---|---|---|
| committer | Linus Torvalds | 2006-02-05 11:06:53 -0800 |
| commit | fe38d8553ccb5237bf0eddda9e94fbca7288551c (patch) | |
| tree | 4ebdcf473fcf7e429536e86346c258514671f044 /arch/i386/kernel/cpu/intel_cacheinfo.c | |
| parent | 170aa3d02614ae621d54af10555e2f48977ae8de (diff) | |
[PATCH] i386 cpu hotplug: don't access freed memory
i386 CPU init code accesses freed init memory when booting a newly-started
processor after CPU hotplug. The cpu_devs array is searched to find the
vendor and it contains pointers to freed data.
Fix that by:
1. Zeroing entries for freed vendor data after bootup.
2. Changing Transmeta, NSC and UMC to all __init[data].
3. Printing a warning (once only) and setting this_cpu
to a safe default when the vendor is not found.
This does not change behavior for AMD systems. They were broken already
but no error was reported.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/i386/kernel/cpu/intel_cacheinfo.c')
| -rw-r--r-- | arch/i386/kernel/cpu/intel_cacheinfo.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/i386/kernel/cpu/intel_cacheinfo.c b/arch/i386/kernel/cpu/intel_cacheinfo.c index af591c73345f..ffe58cee0c48 100644 --- a/arch/i386/kernel/cpu/intel_cacheinfo.c +++ b/arch/i386/kernel/cpu/intel_cacheinfo.c @@ -152,6 +152,7 @@ static int __cpuinit cpuid4_cache_lookup(int index, struct _cpuid4_info *this_le return 0; } +/* will only be called once; __init is safe here */ static int __init find_num_cache_leaves(void) { unsigned int eax, ebx, ecx, edx; |