diff options
| author | Michael Ellerman | 2019-10-24 11:47:30 +1100 |
|---|---|---|
| committer | Michael Ellerman | 2019-10-30 22:55:12 +1100 |
| commit | e44ff9ea8f4c8a90c82f7b85bd4f5e497c841960 (patch) | |
| tree | 5e3daacd6f7303e8ff9616d713de4f87824026a7 /arch/powerpc/tools/relocs_check.sh | |
| parent | b9e0805abf2e92fc275ac5fbd8c1c9a92b00413d (diff) | |
powerpc/tools: Don't quote $objdump in scripts
Some of our scripts are passed $objdump and then call it as
"$objdump". This doesn't work if it contains spaces because we're
using ccache, for example you get errors such as:
./arch/powerpc/tools/relocs_check.sh: line 48: ccache ppc64le-objdump: No such file or directory
./arch/powerpc/tools/unrel_branch_check.sh: line 26: ccache ppc64le-objdump: No such file or directory
Fix it by not quoting the string when we expand it, allowing the shell
to do the right thing for us.
Fixes: a71aa05e1416 ("powerpc: Convert relocs_check to a shell script using grep")
Fixes: 4ea80652dc75 ("powerpc/64s: Tool to flag direct branches from unrelocated interrupt vectors")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191024004730.32135-1-mpe@ellerman.id.au
Diffstat (limited to 'arch/powerpc/tools/relocs_check.sh')
| -rwxr-xr-x | arch/powerpc/tools/relocs_check.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/tools/relocs_check.sh b/arch/powerpc/tools/relocs_check.sh index 2b4e959caa36..7b9fe0a567cf 100755 --- a/arch/powerpc/tools/relocs_check.sh +++ b/arch/powerpc/tools/relocs_check.sh @@ -20,7 +20,7 @@ objdump="$1" vmlinux="$2" bad_relocs=$( -"$objdump" -R "$vmlinux" | +$objdump -R "$vmlinux" | # Only look at relocation lines. grep -E '\<R_' | # These relocations are okay |