aboutsummaryrefslogtreecommitdiff
path: root/crypto/ecb.c
diff options
context:
space:
mode:
authorMichal Kubecek2022-05-23 22:05:24 +0200
committerSteffen Klassert2022-05-25 11:40:05 +0200
commit9c90c9b3e50e16d03c7f87d63e9db373974781e0 (patch)
tree231bd35b2a94827bb80fb27dc77a294b64353207 /crypto/ecb.c
parent8c3b8dc5cc9bf6d273ebe18b16e2d6882bcfb36d (diff)
Revert "net: af_key: add check for pfkey_broadcast in function pfkey_process"
This reverts commit 4dc2a5a8f6754492180741facf2a8787f2c415d7. A non-zero return value from pfkey_broadcast() does not necessarily mean an error occurred as this function returns -ESRCH when no registered listener received the message. In particular, a call with BROADCAST_PROMISC_ONLY flag and null one_sk argument can never return zero so that this commit in fact prevents processing any PF_KEY message. One visible effect is that racoon daemon fails to find encryption algorithms like aes and refuses to start. Excluding -ESRCH return value would fix this but it's not obvious that we really want to bail out here and most other callers of pfkey_broadcast() also ignore the return value. Also, as pointed out by Steffen Klassert, PF_KEY is kind of deprecated and newer userspace code should use netlink instead so that we should only disturb the code for really important fixes. v2: add a comment explaining why is the return value ignored Signed-off-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'crypto/ecb.c')
0 files changed, 0 insertions, 0 deletions