diff options
| author | Young_X | 2018-10-03 12:54:29 +0000 |
|---|---|---|
| committer | Jens Axboe | 2018-10-03 10:20:40 -0600 |
| commit | e4f3aa2e1e67bb48dfbaaf1cad59013d5a5bc276 (patch) | |
| tree | fe85b2c9966c3d9ec4721a2a73d308f7444d7db8 /drivers/cdrom | |
| parent | fb6360b1ef33b7799e6a81e1075a47e3b8ae01fd (diff) | |
cdrom: fix improper type cast, which can leat to information leak.
There is another cast from unsigned long to int which causes
a bounds check to fail with specially crafted input. The value is
then used as an index in the slot array in cdrom_slot_status().
This issue is similar to CVE-2018-16658 and CVE-2018-10940.
Signed-off-by: Young_X <YangX92@hotmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/cdrom')
| -rw-r--r-- | drivers/cdrom/cdrom.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index a5d5a96479bf..10802d1fc554 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -2445,7 +2445,7 @@ static int cdrom_ioctl_select_disc(struct cdrom_device_info *cdi, return -ENOSYS; if (arg != CDSL_CURRENT && arg != CDSL_NONE) { - if ((int)arg >= cdi->capacity) + if (arg >= cdi->capacity) return -EINVAL; } |