diff options
| author | Minjie Du | 2023-07-12 18:22:46 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2023-09-13 09:42:45 +0200 |
| commit | 4a43285900cd4e686f7e9113876a3697b206f180 (patch) | |
| tree | 6a6880a62f02829d6c95e9577b7c714ee7bf5a7b /drivers/clk/keystone | |
| parent | d96da888dcd7edbea54e0bad7d6b20d9138d7e86 (diff) | |
drivers: clk: keystone: Fix parameter judgment in _of_pll_clk_init()
[ Upstream commit a995c50db887ef97f3160775aef7d772635a6f6e ]
The function clk_register_pll() may return NULL or an ERR_PTR. Don't
treat an ERR_PTR as valid.
Signed-off-by: Minjie Du <duminjie@vivo.com>
Link: https://lore.kernel.org/r/20230712102246.10348-1-duminjie@vivo.com
Fixes: b9e0d40c0d83 ("clk: keystone: add Keystone PLL clock driver")
[sboyd@kernel.org: Reword commit text]
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/clk/keystone')
| -rw-r--r-- | drivers/clk/keystone/pll.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c index d59a7621bb20..ee5c72369334 100644 --- a/drivers/clk/keystone/pll.c +++ b/drivers/clk/keystone/pll.c @@ -209,7 +209,7 @@ static void __init _of_pll_clk_init(struct device_node *node, bool pllctrl) } clk = clk_register_pll(NULL, node->name, parent_name, pll_data); - if (clk) { + if (!IS_ERR_OR_NULL(clk)) { of_clk_add_provider(node, of_clk_src_simple_get, clk); return; } |