diff options
| author | Julia Lawall | 2015-10-09 19:47:41 +0200 |
|---|---|---|
| committer | Stephen Boyd | 2015-10-12 11:52:48 -0700 |
| commit | 4e4f485c89c95c317fadf9faf76d703f0cc7a34d (patch) | |
| tree | ba772945fc9aa48d7fa1e8363cecbea91db94938 /drivers/clk/tegra/clk-emc.c | |
| parent | 67d7188afe23e4b1b82ee6fed35c14387f169f74 (diff) | |
clk: tegra: delete unneeded of_node_put
for_each_child_of_node performs an of_node_put on each iteration, so
putting an of_node_put before a continue results in a double put.
The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@
for_each_child_of_node(root, child) {
... when != of_node_get(child)
* of_node_put(child);
...
* continue;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/tegra/clk-emc.c')
| -rw-r--r-- | drivers/clk/tegra/clk-emc.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/clk/tegra/clk-emc.c b/drivers/clk/tegra/clk-emc.c index 138a94b99b5b..e1fe8f35d45c 100644 --- a/drivers/clk/tegra/clk-emc.c +++ b/drivers/clk/tegra/clk-emc.c @@ -491,10 +491,8 @@ struct clk *tegra_clk_register_emc(void __iomem *base, struct device_node *np, for_each_child_of_node(np, node) { err = of_property_read_u32(node, "nvidia,ram-code", &node_ram_code); - if (err) { - of_node_put(node); + if (err) continue; - } /* * Store timings for all ram codes as we cannot read the |