diff options
| author | Armin Wolf | 2021-10-21 21:05:28 +0200 |
|---|---|---|
| committer | Guenter Roeck | 2021-10-21 13:14:27 -0700 |
| commit | 38c5b0dd7d3092c24fc3dbd9ca963fd0e11752f5 (patch) | |
| tree | 571823c2fe23b4dbd043d1533b6f89f458e62465 /drivers/hwmon | |
| parent | 6105870f794ded0306dbff4ab017063e4d0f631a (diff) | |
hwmon: (dell-smm) Use strscpy_pad()
Using strscpy_pad() allows for fewer memory accesses
since memset() will not unconditionally zero-out
the whole buffer.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Acked-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20211021190531.17379-3-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/dell-smm-hwmon.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index 9773d6c0477a..b0c591bb761a 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -25,6 +25,7 @@ #include <linux/platform_device.h> #include <linux/proc_fs.h> #include <linux/seq_file.h> +#include <linux/string.h> #include <linux/smp.h> #include <linux/types.h> #include <linux/uaccess.h> @@ -472,8 +473,7 @@ i8k_ioctl_unlocked(struct file *fp, struct dell_smm_data *data, unsigned int cmd if (restricted && !capable(CAP_SYS_ADMIN)) return -EPERM; - memset(buff, 0, sizeof(buff)); - strscpy(buff, data->bios_machineid, sizeof(buff)); + strscpy_pad(buff, data->bios_machineid, sizeof(buff)); break; case I8K_FN_STATUS: |