aboutsummaryrefslogtreecommitdiff
path: root/drivers/iio
diff options
context:
space:
mode:
authorColin Ian King2018-07-30 13:59:18 +0100
committerJonathan Cameron2018-07-30 19:28:47 +0100
commit1e96e93a3569fd7a4d3199d9d912345ad3b8ce4c (patch)
tree8a709016982e48dffcb072412e835311cedfa4af /drivers/iio
parent9a5094ca29ea9b1da301b31fd377c0c0c4c23034 (diff)
iio: light: si1133 fix test for val being not zero or not one.
The current check on val always results in true and so the call to sii1133_update_adcsens never gets called. Fix this check so it returns with -EINVAL only when val is not zero and not one. Detected by CoverityScan, CID#1472099 ("Logically dead code") Fixes: e01e7eaf37d8 ("iio: light: introduce si1133") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
-rw-r--r--drivers/iio/light/si1133.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
index d3fbeb3bc463..5ac22c46da1f 100644
--- a/drivers/iio/light/si1133.c
+++ b/drivers/iio/light/si1133.c
@@ -838,7 +838,7 @@ static int si1133_write_raw(struct iio_dev *iio_dev,
switch (chan->type) {
case IIO_INTENSITY:
case IIO_UVINDEX:
- if (val != 0 || val != 1)
+ if (val != 0 && val != 1)
return -EINVAL;
return si1133_update_adcsens(data,