diff options
| author | Jens Axboe | 2015-03-06 08:37:46 -0700 |
|---|---|---|
| committer | Jens Axboe | 2015-07-11 09:57:32 -0600 |
| commit | 77b5a08427e87514c33730afc18cd02c9475e2c3 (patch) | |
| tree | b0d325533280f47253871044e875c0f71a369896 /drivers/md/bcache/closure.h | |
| parent | 06b285bd11257bccc5a1b85a835507e33656aff2 (diff) | |
bcache: don't embed 'return' statements in closure macros
This is horribly confusing, it breaks the flow of the code without
it being apparent in the caller.
Signed-off-by: Jens Axboe <axboe@fb.com>
Acked-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/md/bcache/closure.h')
| -rw-r--r-- | drivers/md/bcache/closure.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h index a08e3eeac3c5..79a6d63e8ed3 100644 --- a/drivers/md/bcache/closure.h +++ b/drivers/md/bcache/closure.h @@ -320,7 +320,6 @@ static inline void closure_wake_up(struct closure_waitlist *list) do { \ set_closure_fn(_cl, _fn, _wq); \ closure_sub(_cl, CLOSURE_RUNNING + 1); \ - return; \ } while (0) /** @@ -349,7 +348,6 @@ do { \ do { \ set_closure_fn(_cl, _fn, _wq); \ closure_queue(_cl); \ - return; \ } while (0) /** @@ -365,7 +363,6 @@ do { \ do { \ set_closure_fn(_cl, _destructor, NULL); \ closure_sub(_cl, CLOSURE_RUNNING - CLOSURE_DESTRUCTOR + 1); \ - return; \ } while (0) /** |