diff options
author | Arnd Bergmann | 2018-01-02 11:48:54 +0100 |
---|---|---|
committer | Greg Kroah-Hartman | 2018-01-02 17:05:17 +0100 |
commit | c127f98ba9aba1818a6ca3a1da5a24653a10d966 (patch) | |
tree | 0925dff88854afa457b8ac6b8b9f1d14103bc9f2 /drivers/misc | |
parent | b6a09416e83ffe4eccfb4ef1b91b3b66483fa810 (diff) |
slimbus: qcom-ctrl: use normal allocation
The previous patch addressed a warning but not the cause:
drivers/slimbus/qcom-ctrl.c: In function 'qcom_slim_probe':
drivers/slimbus/qcom-ctrl.c:584:9: error: passing argument 3 of 'dmam_alloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
There are two things wrong here:
- The naming is very confusing, we now have a member named 'phys'
that doesn't refer to a phys_addr_t but a dma_addr_t. If we needed
a dma address, it should be named 'dma' to avoid confusion, and
to make it less likely that someone passes it into a function that
expects a physical address.
- The dma address is not used at all at this point. It may have been
designed to support DMA in the future, but today it doesn't, so
the only effect right now is to make transfers artificially slower
by using uncached memory instead of cached memory for a temporary
buffer.
This removes the unused structure member and instead changes the code
to call devm_kcalloc(), which matches the usage of the 'base' pointer
as an array of temporary buffers.
Fixes: db809859c8ce ("slimbus: qcom: fix incompatible pointer warning")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
0 files changed, 0 insertions, 0 deletions