diff options
| author | Arnd Bergmann | 2017-02-17 16:08:30 +0100 |
|---|---|---|
| committer | David S. Miller | 2017-02-17 15:25:49 -0500 |
| commit | fbdf0e28d061708cf18ba0f8e0db5360dc9a15b9 (patch) | |
| tree | 57b98b6fb5b7411be4180fafafb572af85dd0854 /drivers/net | |
| parent | 74179d44b6e199adaec8c7d842dc61ebefa314c5 (diff) | |
vmxnet3: prevent building with 64K pages
I got a warning about broken code on ARM64 with 64K pages:
drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init':
drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
rq->buf_info[0][i].len = PAGE_SIZE;
'len' here is a 16-bit integer, so this clearly won't work. I don't think
this driver is used much on anything other than x86, so there is no need
to fix this properly and we can work around it with a Kconfig dependency
to forbid known-broken configurations. qemu in theory supports it on
other architectures too, but presumably only for compatibility with x86
guests that also run on vmware.
CONFIG_PAGE_SIZE_64KB is used on hexagon, mips, sh and tile, the other
symbols are architecture-specific names for the same thing.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/Kconfig | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 823bc2fd201f..100fbdc9b95c 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -460,6 +460,9 @@ config XEN_NETDEV_BACKEND config VMXNET3 tristate "VMware VMXNET3 ethernet driver" depends on PCI && INET + depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \ + IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \ + PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES) help This driver supports VMware's vmxnet3 virtual ethernet NIC. To compile this driver as a module, choose M here: the |