diff options
author | Anton Blanchard | 2017-04-03 16:41:02 +1000 |
---|---|---|
committer | Michael Ellerman | 2017-04-03 23:33:05 +1000 |
commit | a7a9dcd882a67b68568868b988289fce5ffd8419 (patch) | |
tree | 5b52f9a420f3d73a50e598b8aee5faed79af91e2 /drivers/of | |
parent | 63f44d65143976af9b28cf70ebe23f2c8b38677a (diff) |
powerpc: Avoid taking a data miss on every userspace instruction miss
Early on in do_page_fault() we call store_updates_sp(), regardless of
the type of exception. For an instruction miss this doesn't make
sense, because we only use this information to detect if a data miss
is the result of a stack expansion instruction or not.
Worse still, it results in a data miss within every userspace
instruction miss handler, because we try and load the very instruction
we are about to install a pte for!
A simple exec microbenchmark runs 6% faster on POWER8 with this fix:
#include <stdlib.h>
#include <stdio.h>
#include <unistd.h>
int main(int argc, char *argv[])
{
unsigned long left = atol(argv[1]);
char leftstr[16];
if (left-- == 0)
return 0;
sprintf(leftstr, "%ld", left);
execlp(argv[0], argv[0], leftstr, NULL);
perror("exec failed\n");
return 0;
}
Pass the number of iterations on the command line (eg 10000) and time
how long it takes to execute.
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'drivers/of')
0 files changed, 0 insertions, 0 deletions