diff options
| author | Andrzej Hajda | 2015-12-10 08:55:33 +0100 |
|---|---|---|
| committer | Alexandre Belloni | 2016-01-11 20:20:00 +0100 |
| commit | 68c85f2916222b15556ca44e2da0ee94f61f02da (patch) | |
| tree | d58f5636377c5bf1fb50f71bc2ee8787dd694c45 /drivers/rtc | |
| parent | ed13d89b08e392cd347aaa54ddc17f7d3e26b175 (diff) | |
rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/rtc-rv8803.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index e7329e21bfe3..f883aa266d0c 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -61,7 +61,7 @@ static irqreturn_t rv8803_handle_irq(int irq, void *dev_id) struct i2c_client *client = dev_id; struct rv8803_data *rv8803 = i2c_get_clientdata(client); unsigned long events = 0; - u8 flags; + int flags; spin_lock(&rv8803->flags_lock); |