diff options
author | Dan Williams | 2012-06-21 23:36:20 -0700 |
---|---|---|
committer | James Bottomley | 2012-07-20 08:58:53 +0100 |
commit | b17caa174a7e1fd2e17b26e210d4ee91c4c28b37 (patch) | |
tree | 5ecdb47d968389d9386e5e5c96fe647a8bb04e7b /drivers/scsi/libsas/sas_discover.c | |
parent | 26f2f199ff150d8876b2641c41e60d1c92d2fb81 (diff) |
[SCSI] libsas: fix sas_discover_devices return code handling
commit 198439e4 [SCSI] libsas: do not set res = 0 in sas_ex_discover_dev()
commit 19252de6 [SCSI] libsas: fix wide port hotplug issues
The above commits seem to have confused the return value of
sas_ex_discover_dev which is non-zero on failure and
sas_ex_join_wide_port which just indicates short circuiting discovery on
already established ports. The result is random discovery failures
depending on configuration.
Calls to sas_ex_join_wide_port are the source of the trouble as its
return value is errantly assigned to 'res'. Convert it to bool and stop
returning its result up the stack.
Cc: <stable@vger.kernel.org>
Tested-by: Dan Melnic <dan.melnic@amd.com>
Reported-by: Dan Melnic <dan.melnic@amd.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/libsas/sas_discover.c')
0 files changed, 0 insertions, 0 deletions