diff options
author | Tomas Henzl | 2011-12-01 21:38:42 -0600 |
---|---|---|
committer | James Bottomley | 2011-12-14 15:40:43 +0400 |
commit | e1cd89c507b41e4021ce6fb0d19d230f6a932ccd (patch) | |
tree | ba0d664e4eb08f3b8c59468e447f824fa6534142 /drivers/scsi/qla4xxx/ql4_os.c | |
parent | 13483730a13bef372894aefcf73760f5c6c297be (diff) |
[SCSI] qla4xxx: a small loop fix
When the qla4xxx_get_fwddb_entry returns QLA_ERROR
the nex_idx is not updated,
for (idx = 0; idx < max_ddbs; idx = next_idx) {
ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
&next_idx, &state, &conn_err,
NULL, NULL);
if (ret == QLA_ERROR)
continue;
This means there is a risk that the 'idx < max_ddbs' condition will never
met and the loop will loop forever.
Fix this by explicitly increasing the next_idx in the error condition.
Maybe a break instead of continue is more appropriate, leaving the decision
on the qlogic maintainer.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/qla4xxx/ql4_os.c')
0 files changed, 0 insertions, 0 deletions