diff options
author | Pavel Fedin | 2015-12-08 10:37:44 +0300 |
---|---|---|
committer | David S. Miller | 2015-12-08 22:44:55 -0500 |
commit | f406ce4234149c302a7acb0be01c08de7b40bdb5 (patch) | |
tree | 15d0f645273f80035bfc03131ab53c001f5867f7 /drivers/sfi/Kconfig | |
parent | a322a1bcf32900e9c9f4f9d3e09717513d918cdc (diff) |
net: thunderx: Correctly distinguish between VF and LMAC count
Commit bc69fdfc6c13
("net: thunderx: Enable BGX LMAC's RX/TX only after VF is up")
introduces lmac_cnt member and starts verifying VF number against it.
This is plain wrong, and works only because currently we have hardcoded
1:1 mapping between VFs and LMACs, and in this case num_vf_en and
lmac_cnt are always equal. However in future this may change, and the
code will badly misbehave. The worst consequence of this is failure to
deliver link status messages, causing VFs to go defunct because since
commit 0b72a9a1060e ("net: thunderx: Switchon carrier only upon
interface link up") VF will not fully bring itself up without it.
This patch fixes the potential problem by doing VF number checks against
the num_vf_en. Since lmac_cnt is not used anywhere else, it is removed.
Additionally some duplicated code is factored out into nic_enable_vf()
Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/sfi/Kconfig')
0 files changed, 0 insertions, 0 deletions