diff options
author | Gustavo A. R. Silva | 2020-03-02 06:10:51 -0600 |
---|---|---|
committer | David S. Miller | 2020-03-02 11:16:28 -0800 |
commit | 8f5c69f96a5030899437e3e76dc4495c99e2258a (patch) | |
tree | 200b5e59295739eb5d60b3c980282ef54dc727d9 /drivers/spi/spi-rspi.c | |
parent | 48b77df665e0a268b61a795208e647b6b7bb7e00 (diff) |
bna: bnad: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/spi/spi-rspi.c')
0 files changed, 0 insertions, 0 deletions