diff options
| author | Jiri Slaby | 2021-06-18 08:15:06 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2021-06-18 13:10:02 +0200 |
| commit | 265ceff7aeaa1001b4bea810e1b832d138352b3f (patch) | |
| tree | 054adbe337f7e0fc172d7bcf71faf2d2f422e898 /drivers/tty | |
| parent | 740165f7acbf1e73e6a7bfa2e8642b2e86cdee94 (diff) | |
mxser: remove xmit_cnt < 0 tests
mxser_port::xmit_cnt is unsigned, it cannot be negative. Therefore
remove all the xmit_cnt < 0 tests.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-61-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/mxser.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index e46974e9421a..1a8698e58b1c 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -995,7 +995,7 @@ static void mxser_flush_chars(struct tty_struct *tty) { struct mxser_port *info = tty->driver_data; - if (info->xmit_cnt <= 0 || tty->flow.stopped || !info->port.xmit_buf || + if (!info->xmit_cnt || tty->flow.stopped || !info->port.xmit_buf || (tty->hw_stopped && info->type != PORT_16550A && !info->board->must_hwid)) return; @@ -1652,7 +1652,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port if (port->port.xmit_buf == NULL) return; - if (port->xmit_cnt <= 0 || tty->flow.stopped || + if (!port->xmit_cnt || tty->flow.stopped || (tty->hw_stopped && (port->type != PORT_16550A) && (!port->board->must_hwid))) { @@ -1666,7 +1666,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port outb(port->port.xmit_buf[port->xmit_tail++], port->ioaddr + UART_TX); port->xmit_tail = port->xmit_tail & (SERIAL_XMIT_SIZE - 1); - if (--port->xmit_cnt <= 0) + if (!--port->xmit_cnt) break; } while (--count > 0); @@ -1675,7 +1675,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port if (port->xmit_cnt < WAKEUP_CHARS) tty_wakeup(tty); - if (port->xmit_cnt <= 0) + if (!port->xmit_cnt) __mxser_stop_tx(port); } |