aboutsummaryrefslogtreecommitdiff
path: root/drivers/usb/host/ehci-exynos.c
diff options
context:
space:
mode:
authorVivek Gautam2014-05-10 17:30:05 +0530
committerGreg Kroah-Hartman2014-05-27 14:52:29 -0700
commit4e24bde33fd26af51b2f0c69ec5a5d847f6f26a5 (patch)
tree69e9d8430fb14caa79459636b0a93063f75ab409 /drivers/usb/host/ehci-exynos.c
parent1c17675d6c733232f10afceec0bcd016ad3849f0 (diff)
usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap
Using devm_ioremap_resource() API should actually be preferred over devm_ioremap(), since the former request the mem region first and then gives back the ioremap'ed memory pointer. devm_ioremap_resource() calls request_mem_region(), therby preventing other drivers to make any overlapping call to the same region. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/ehci-exynos.c')
-rw-r--r--drivers/usb/host/ehci-exynos.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index c7081c75de8a..d1c76216350f 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -218,10 +218,9 @@ skip_phy:
hcd->rsrc_start = res->start;
hcd->rsrc_len = resource_size(res);
- hcd->regs = devm_ioremap(&pdev->dev, res->start, hcd->rsrc_len);
- if (!hcd->regs) {
- dev_err(&pdev->dev, "Failed to remap I/O memory\n");
- err = -ENOMEM;
+ hcd->regs = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(hcd->regs)) {
+ err = PTR_ERR(hcd->regs);
goto fail_io;
}