diff options
| author | Greg Kroah-Hartman | 2023-02-02 16:32:27 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2023-03-11 13:55:36 +0100 |
| commit | 7d2d3bef6d700eb4261fb6761de2c95a9e3c0ac8 (patch) | |
| tree | 294d3a50caf5e7aa05a3f2cc59c98a233eb1d7fe /drivers/usb | |
| parent | 54166af8941d0cf46b65cfa2fbce76e38d82fadf (diff) | |
USB: fotg210: fix memory leak with using debugfs_lookup()
[ Upstream commit 6b4040f452037a7e95472577891d57c6b18c89c5 ]
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230202153235.2412790-5-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/host/fotg210-hcd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index 3d1dbcf4c073..c4c1fbc12b4c 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -862,7 +862,7 @@ static inline void remove_debug_files(struct fotg210_hcd *fotg210) { struct usb_bus *bus = &fotg210_to_hcd(fotg210)->self; - debugfs_remove(debugfs_lookup(bus->bus_name, fotg210_debug_root)); + debugfs_lookup_and_remove(bus->bus_name, fotg210_debug_root); } /* handshake - spin reading hc until handshake completes or fails |