diff options
author | Dan Carpenter | 2021-12-08 18:09:56 +0300 |
---|---|---|
committer | Michael S. Tsirkin | 2021-12-08 14:53:15 -0500 |
commit | dc1db0060c02d119fd4196924eff2d1129e9a442 (patch) | |
tree | b8ffb6cbb2d403e16c523d6fa9ebf463c4f51104 /drivers/video/fbdev/p9100.c | |
parent | 3ed21c1451a14d139e1ceb18f2fa70865ce3195a (diff) |
vduse: check that offset is within bounds in get_config()
This condition checks "len" but it does not check "offset" and that
could result in an out of bounds read if "offset > dev->config_size".
The problem is that since both variables are unsigned the
"dev->config_size - offset" subtraction would result in a very high
unsigned value.
I think these checks might not be necessary because "len" and "offset"
are supposed to already have been validated using the
vhost_vdpa_config_validate() function. But I do not know the code
perfectly, and I like to be safe.
Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211208150956.GA29160@kili
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/video/fbdev/p9100.c')
0 files changed, 0 insertions, 0 deletions