diff options
| author | Julia Lawall | 2010-02-08 22:44:18 -0800 |
|---|---|---|
| committer | David S. Miller | 2010-02-08 22:44:18 -0800 |
| commit | bcf4d812e66ee95f762b38063d654fd1ff7156b0 (patch) | |
| tree | 7b56aa70d64d4f4da6a73cb75974bbc7c05d51e5 /drivers | |
| parent | 3af26f58d1920d904da87c3897d23070fe2266b4 (diff) | |
drivers/net: Correct NULL test
Test the value that was just allocated rather than the previously tested one.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@
if (x == NULL || ...) {
... when forall
return ...; }
... when != goto l;
when != x = e
when != &x
*x == NULL
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ax88796.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c index 62d9c9cc5671..1dd4403247ca 100644 --- a/drivers/net/ax88796.c +++ b/drivers/net/ax88796.c @@ -921,7 +921,7 @@ static int ax_probe(struct platform_device *pdev) size = (res->end - res->start) + 1; ax->mem2 = request_mem_region(res->start, size, pdev->name); - if (ax->mem == NULL) { + if (ax->mem2 == NULL) { dev_err(&pdev->dev, "cannot reserve registers\n"); ret = -ENXIO; goto exit_mem1; |