diff options
| author | Octavian Purdila | 2014-11-18 14:57:58 +0200 |
|---|---|---|
| committer | Lee Jones | 2014-11-19 17:12:37 +0000 |
| commit | 9331642812b19313ca4c545b37c001d68efb7022 (patch) | |
| tree | 4ca83613a77752f700b816398c5e29ffd99e294e /drivers | |
| parent | 7ca2b1c6724b150d8305ce06e4b07904ecbcb3fb (diff) | |
i2c: dln2: Simplify return flow for dln2_i2c_enable
This fixes the following kbuild test robot warning:
>> drivers/i2c/busses/i2c-dln2.c:70:1-4: WARNING: end returns can be simplified if negative or 0 value
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/i2c/busses/i2c-dln2.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/i2c/busses/i2c-dln2.c b/drivers/i2c/busses/i2c-dln2.c index 010a5fa8c883..b3fb86af4cbb 100644 --- a/drivers/i2c/busses/i2c-dln2.c +++ b/drivers/i2c/busses/i2c-dln2.c @@ -54,7 +54,6 @@ struct dln2_i2c { static int dln2_i2c_enable(struct dln2_i2c *dln2, bool enable) { - int ret; u16 cmd; struct { u8 port; @@ -67,11 +66,7 @@ static int dln2_i2c_enable(struct dln2_i2c *dln2, bool enable) else cmd = DLN2_I2C_DISABLE; - ret = dln2_transfer_tx(dln2->pdev, cmd, &tx, sizeof(tx)); - if (ret < 0) - return ret; - - return 0; + return dln2_transfer_tx(dln2->pdev, cmd, &tx, sizeof(tx)); } static int dln2_i2c_write(struct dln2_i2c *dln2, u8 addr, |