diff options
author | Jay Vosburgh | 2015-11-06 17:23:23 -0800 |
---|---|---|
committer | David S. Miller | 2015-11-07 13:17:32 -0500 |
commit | 40baec225765c54eefa870530dd613bad9829bb7 (patch) | |
tree | 566bdfce1bbe7c5297c497477fedf413e2890b4f /firmware/yamaha | |
parent | e824de8ae2a00ee71c5bfbadd004d12c6dd85561 (diff) |
bonding: fix panic on non-ARPHRD_ETHER enslave failure
Since commit 7d5cd2ce529b, when bond_enslave fails on devices that
are not ARPHRD_ETHER, if needed, it resets the bonding device back to
ARPHRD_ETHER by calling ether_setup.
Unfortunately, ether_setup clobbers dev->flags, clearing IFF_UP
if the bond device is up, leaving it in a quasi-down state without
having actually gone through dev_close. For bonding, if any periodic
work queue items are active (miimon, arp_interval, etc), those will
remain running, as they are stopped by bond_close. At this point, if
the bonding module is unloaded or the bond is deleted, the system will
panic when the work function is called.
This panic is resolved by calling dev_close on the bond itself
prior to calling ether_setup.
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Fixes: 7d5cd2ce5292 ("bonding: correctly handle bonding type change on enslave failure")
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'firmware/yamaha')
0 files changed, 0 insertions, 0 deletions