diff options
| author | Sasha Levin | 2023-01-04 11:14:45 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2023-01-12 12:01:55 +0100 |
| commit | 0af9640736a61f1404e4d64a088491d24cb0bdb3 (patch) | |
| tree | d260389ee52a9066afa4303537a839f195d4626d /fs/btrfs/rcu-string.h | |
| parent | 7578a7c0f296b678259ea852649276e7078064d7 (diff) | |
btrfs: replace strncpy() with strscpy()
[ Upstream commit 63d5429f68a3d4c4aa27e65a05196c17f86c41d6 ]
Using strncpy() on NUL-terminated strings are deprecated. To avoid
possible forming of non-terminated string strscpy() should be used.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
CC: stable@vger.kernel.org # 4.9+
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/btrfs/rcu-string.h')
| -rw-r--r-- | fs/btrfs/rcu-string.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/btrfs/rcu-string.h b/fs/btrfs/rcu-string.h index 5c1a617eb25d..5c2b66d155ef 100644 --- a/fs/btrfs/rcu-string.h +++ b/fs/btrfs/rcu-string.h @@ -18,7 +18,11 @@ static inline struct rcu_string *rcu_string_strdup(const char *src, gfp_t mask) (len * sizeof(char)), mask); if (!ret) return ret; - strncpy(ret->str, src, len); + /* Warn if the source got unexpectedly truncated. */ + if (WARN_ON(strscpy(ret->str, src, len) < 0)) { + kfree(ret); + return NULL; + } return ret; } |