diff options
| author | Filipe Manana | 2023-04-26 11:51:35 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2023-06-09 10:34:07 +0200 |
| commit | 0433baa89318728b5e451a67b8d16f1d21f5e2dd (patch) | |
| tree | 943b421c558f722d0f5ede88f95154a87df8a33e /fs/buffer.c | |
| parent | e2d161c539a4e1d48e4575d9fbcbcd09762899d6 (diff) | |
btrfs: abort transaction when sibling keys check fails for leaves
[ Upstream commit 9ae5afd02a03d4e22a17a9609b19400b77c36273 ]
If the sibling keys check fails before we move keys from one sibling
leaf to another, we are not aborting the transaction - we leave that to
some higher level caller of btrfs_search_slot() (or anything else that
uses it to insert items into a b+tree).
This means that the transaction abort will provide a stack trace that
omits the b+tree modification call chain. So change this to immediately
abort the transaction and therefore get a more useful stack trace that
shows us the call chain in the bt+tree modification code.
It's also important to immediately abort the transaction just in case
some higher level caller is not doing it, as this indicates a very
serious corruption and we should stop the possibility of doing further
damage.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/buffer.c')
0 files changed, 0 insertions, 0 deletions