diff options
author | Ross Zwisler | 2016-02-27 14:01:13 -0500 |
---|---|---|
committer | Theodore Ts'o | 2016-02-27 14:01:16 -0500 |
commit | 1e9d180ba39f42e8ca4a808baef3a3ef034b1c2c (patch) | |
tree | 130440fffa2025bff83c906f797afbb395529e00 /fs/dax.c | |
parent | 74dae4278546b897eb81784fdfcce872ddd8b2b8 (diff) |
ext2, ext4: fix issue with missing journal entry in ext4_dax_mkwrite()
As it is currently written ext4_dax_mkwrite() assumes that the call into
__dax_mkwrite() will not have to do a block allocation so it doesn't create
a journal entry. For a read that creates a zero page to cover a hole
followed by a write that actually allocates storage this is incorrect. The
ext4_dax_mkwrite() -> __dax_mkwrite() -> __dax_fault() path calls
get_blocks() to allocate storage.
Fix this by having the ->page_mkwrite fault handler call ext4_dax_fault()
as this function already has all the logic needed to allocate a journal
entry and call __dax_fault().
Also update the ext2 fault handlers in this same way to remove duplicate
code and keep the logic between ext2 and ext4 the same.
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/dax.c')
0 files changed, 0 insertions, 0 deletions