diff options
author | Darrick J. Wong | 2022-05-20 14:41:42 +1000 |
---|---|---|
committer | Dave Chinner | 2022-05-20 14:41:42 +1000 |
commit | a618acab136b1b01a4c10957ce8bae70cc9f7ca4 (patch) | |
tree | 676dc1f9ab0fe71e9aa64443ea6050558163601a /fs/gfs2/aops.c | |
parent | 309001c22cdd75c62e6c3a217bf6967e178f929a (diff) |
xfs: don't leak the retained da state when doing a leaf to node conversion
If a setxattr operation finds an xattr structure in leaf format, adding
the attr can fail due to lack of space and hence requires an upgrade to
node format. After this happens, we'll roll the transaction and
re-enter the state machine, at which time we need to perform a second
lookup of the attribute name to find its new location. This lookup
attaches a new da state structure to the xfs_attr_item but doesn't free
the old one (from the leaf lookup) and leaks it. Fix that.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/gfs2/aops.c')
0 files changed, 0 insertions, 0 deletions