diff options
| author | Al Viro | 2015-05-03 21:30:27 -0400 |
|---|---|---|
| committer | Al Viro | 2015-05-10 22:20:08 -0400 |
| commit | e269f2a73f92b40169c4229289587b901a00b244 (patch) | |
| tree | 82e84cfdbdca3aa200804e51aaaca78bf1757b9c /fs/namei.c | |
| parent | 8eff733a45c98f17f254a313859f3b3ed9fc12dc (diff) | |
namei: we never need more than MAXSYMLINKS entries in nd->stack
The only reason why we needed one more was that purely nested
MAXSYMLINKS symlinks could lead to path_init() using that many
entries in addition to nd->stack[0] which it left unused.
That can't happen now - path_init() starts with entry 0 (and
trailing_symlink() is called only when we'd already encountered
one symlink, so no more than MAXSYMLINKS-1 are left).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/namei.c')
| -rw-r--r-- | fs/namei.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/namei.c b/fs/namei.c index d12b16c13f0c..b939f488bc6f 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -528,7 +528,7 @@ static void restore_nameidata(struct nameidata *nd) static int __nd_alloc_stack(struct nameidata *nd) { - struct saved *p = kmalloc((MAXSYMLINKS + 1) * sizeof(struct saved), + struct saved *p = kmalloc(MAXSYMLINKS * sizeof(struct saved), GFP_KERNEL); if (unlikely(!p)) return -ENOMEM; |