diff options
| author | NeilBrown | 2016-10-13 15:26:47 +1100 |
|---|---|---|
| committer | Trond Myklebust | 2016-12-01 17:57:56 -0500 |
| commit | 1739347549653dc2463d208d7039f5e97b8f1e8b (patch) | |
| tree | 8d9421e7d74b30a01cc13099a9eb30d4e588086e /fs/nfs/nfs4proc.c | |
| parent | 29b59f94169374c412cedf60c77073df4e68ce51 (diff) | |
NFSv4: change nfs4_select_rw_stateid to take a lock_context inplace of lock_owner
The only time that a lock_context is not immediately available is in
setattr, and now that it has an open_context, it can easily find one
with nfs_get_lock_context.
This removes the need for the on-stack nfs_lockowner.
This change is preparation for correctly support flock stateids.
Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs/nfs4proc.c')
| -rw-r--r-- | fs/nfs/nfs4proc.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 3ab4dd5f7cfb..1c629f5e1ae5 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2945,12 +2945,13 @@ static int _nfs4_do_setattr(struct inode *inode, if (nfs4_copy_delegation_stateid(inode, fmode, &arg->stateid, &delegation_cred)) { /* Use that stateid */ } else if (truncate && ctx != NULL) { - struct nfs_lockowner lockowner = { - .l_owner = current->files, - }; + struct nfs_lock_context *l_ctx; if (!nfs4_valid_open_stateid(ctx->state)) return -EBADF; - if (nfs4_select_rw_stateid(ctx->state, FMODE_WRITE, &lockowner, + l_ctx = nfs_get_lock_context(ctx); + if (IS_ERR(l_ctx)) + return PTR_ERR(l_ctx); + if (nfs4_select_rw_stateid(ctx->state, FMODE_WRITE, l_ctx, &arg->stateid, &delegation_cred) == -EIO) return -EBADF; } else @@ -4576,11 +4577,7 @@ int nfs4_set_rw_stateid(nfs4_stateid *stateid, const struct nfs_lock_context *l_ctx, fmode_t fmode) { - const struct nfs_lockowner *lockowner = NULL; - - if (l_ctx != NULL) - lockowner = &l_ctx->lockowner; - return nfs4_select_rw_stateid(ctx->state, fmode, lockowner, stateid, NULL); + return nfs4_select_rw_stateid(ctx->state, fmode, l_ctx, stateid, NULL); } EXPORT_SYMBOL_GPL(nfs4_set_rw_stateid); |