diff options
| author | Christian Brauner | 2022-11-03 08:18:46 +0100 |
|---|---|---|
| committer | Christian Brauner (Microsoft) | 2022-11-03 08:18:46 +0100 |
| commit | 5b52aebef8954cadff29918bb61d7fdc7be07837 (patch) | |
| tree | 2e2eafedc756efbeccf4eaedbf5afb3f4fe3309c /fs/overlayfs | |
| parent | 16257cf6658d5bde2a055caf48f143c255abade7 (diff) | |
ovl: call posix_acl_release() after error checking
The current placement of posix_acl_release() in ovl_set_or_remove_acl()
means it can be called on an error pointer instead of actual acls.
Fix this by moving the posix_acl_release() call after the error handling.
Fixes: 0e641857322f ("ovl: implement set acl method") # mainline only
Reported-by: syzbot+3f6ef1c4586bb6fd1f61@syzkaller.appspotmail.com
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Diffstat (limited to 'fs/overlayfs')
| -rw-r--r-- | fs/overlayfs/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index 77a77fd7a77b..ee6dfa577c93 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -621,11 +621,11 @@ static int ovl_set_or_remove_acl(struct dentry *dentry, struct inode *inode, real_acl = vfs_get_acl(mnt_user_ns(realpath.mnt), realdentry, acl_name); revert_creds(old_cred); - posix_acl_release(real_acl); if (IS_ERR(real_acl)) { err = PTR_ERR(real_acl); goto out_drop_write; } + posix_acl_release(real_acl); } if (!upperdentry) { |