diff options
| author | Hiroshi Shimamoto | 2008-02-14 10:27:00 -0800 |
|---|---|---|
| committer | Ingo Molnar | 2008-02-25 16:34:17 +0100 |
| commit | d6643d12cb0885d06a1491b16c1476abcbd53d40 (patch) | |
| tree | f342c01a278486e47a973cc84ffac72c43b57c64 /fs/proc | |
| parent | ae0027869db7d28563cd783865fab04ffd18419c (diff) | |
latencytop: fix memory leak on latency proc file
At lstats_open(), calling get_proc_task() gets task struct, but it never put.
put_task_struct() should be called when releasing.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'fs/proc')
| -rw-r--r-- | fs/proc/base.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/fs/proc/base.c b/fs/proc/base.c index 989e3078d7af..85e06e498078 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -360,6 +360,15 @@ static int lstats_open(struct inode *inode, struct file *file) return ret; } +static int lstats_release(struct inode *inode, struct file *file) +{ + struct seq_file *m = file->private_data; + struct task_struct *task = m->private; + + put_task_struct(task); + return single_release(inode, file); +} + static ssize_t lstats_write(struct file *file, const char __user *buf, size_t count, loff_t *offs) { @@ -378,7 +387,7 @@ static const struct file_operations proc_lstats_operations = { .read = seq_read, .write = lstats_write, .llseek = seq_lseek, - .release = single_release, + .release = lstats_release, }; #endif |