diff options
| author | Eric W. Biederman | 2010-02-12 19:22:24 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2010-03-07 17:04:52 -0800 |
| commit | 19c38b632d4554329986021fd66bdea468cf452c (patch) | |
| tree | a724445bc46a4500ff6c4def2a6de39fc438f8b5 /fs | |
| parent | f8d4f618fed5a4978afada52166bc2efaf7656d1 (diff) | |
sysfs: Pack sysfs_dirent more tightly.
Placing the 16bit s_mode between a pointer and a long doesn't pack well
especailly on 64bit where we wast 48 bits. So move s_mode and
declare it as a unsigned short. This is the sysfs backing store
after all we don't need fields extra large just in case someday
we want userspace to be able to use a larger value.
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/sysfs/sysfs.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index 37e0e086233c..5a3192a08442 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h @@ -66,8 +66,8 @@ struct sysfs_dirent { }; unsigned int s_flags; + unsigned short s_mode; ino_t s_ino; - umode_t s_mode; struct sysfs_inode_attrs *s_iattr; }; |